Fix: prevent clicks on entire document when dragging

katspaugh · Nov 26, 2023 · 4c1a8a3 · 4c1a8a3
1 parent 895734e
commit 4c1a8a3
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/draggable.ts b/src/draggable.ts
@@ -46,7 +46,6 @@ export function makeDraggable(
 
     const onPointerUp = () => {
       if (isDragging) {
-        isDragging = false
         onEnd?.()
       }
       unsubscribeDocument()
@@ -69,15 +68,15 @@ export function makeDraggable(
     document.addEventListener('pointerup', onPointerUp)
     document.addEventListener('pointercancel', onPointerUp)
     document.addEventListener('touchmove', onTouchMove, { passive: false })
-    element.addEventListener('click', onClick, { capture: true })
+    document.addEventListener('click', onClick, { capture: true })
 
     unsubscribeDocument = () => {
       document.removeEventListener('pointermove', onPointerMove)
       document.removeEventListener('pointerup', onPointerUp)
       document.removeEventListener('pointercancel', onPointerUp)
       document.removeEventListener('touchmove', onTouchMove)
       setTimeout(() => {
-        element.removeEventListener('click', onClick, { capture: true })
+        document.removeEventListener('click', onClick, { capture: true })
       }, 10)
     }
   }