-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
destroy() method throws DOMException error #3637
Comments
@akici can you provide me a minimum reproducible repo to check if the abort error is expected? This PR will help you save network bandwidth and even help you avoid the risk of memory leaks, at least this is one of the reasons for the memory leak problem in my system. we can focus on the following:
|
@wfk007 Here is the code example.
|
@akici @katspaugh I figured out the reason:
|
@katspaugh I opened a pr to fix it: https://github.com/katspaugh/wavesurfer.js/pull/3641/files, Please help me review it at your convenience. |
Works like a charm, cheers @katspaugh! |
Thank you! @wfk007 |
Bug description
destroy() method throws the following DOMException since v7.7.6. Related Commit. Looks like it's related to AbortController object.
Environment
Stack trace
Minimal code snippet
Expected result
Not having exception
Obtained result
DOMException
Screenshots
The text was updated successfully, but these errors were encountered: