docs: add test cases for abort and destroy #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm weird why the e2e works locally but keeps failing in GitHub jobs |
wfk007
force-pushed
the
add-abort-test-cases
branch
from
bd587b1 to
a8c01da
Compare
|
Indeed, that's weird. I'll try on my machine locally. |
|
Fixed it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
add two test cases for abort, refer to: #3641 (comment)
Implementation details
case1: destroy before wavesurfer ready should emit AbortError Exception, it is for #3614
case2: load url after destroyed should not emit AbortError Exception, it is for #3637
How to test it
yarn run cypress
Screenshots
Checklist