Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fftSamples shouldn't scale the spectrogram image #3663

Closed
wxfred opened this issue Apr 17, 2024 · 0 comments · Fixed by #3796
Closed

fftSamples shouldn't scale the spectrogram image #3663

wxfred opened this issue Apr 17, 2024 · 0 comments · Fixed by #3796

Comments

@wxfred
Copy link

wxfred commented Apr 17, 2024

Bug description

On the page https://wavesurfer.xyz/examples/?spectrogram.js, set the Spectrogram plugin option fftSamples from 1024 to 128 (or others), the height of the spectrogram image will change.

Environment

  • Browser: Chrome

Expected result

The fftSamples parameter only affects the resolution of the image, not its height.
I think the final image should be stretched to cover the whole range.
If the sample rate is 48000Hz, the image should always cover 0 - 24000Hz, independent of fftSamples.
The lower fftSamples means the highlights in the image will be more blur, more like a mosaic effect.

Screenshots

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants