-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Parse date
, lastmod
and notes from LOGBOOK drawers
#504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a988824
to
d7d867c
Compare
SpecOrg note heading settingsAssume that user has kept the default value of Parsing state changes
Above exports to this in TOML front-matter: date = 2018-09-06T11:25:00-04:00
draft = false Parsing notes added to LOGBOOK drawers using
|
c4bcdcc
to
eae343f
Compare
TTA: TOML Table Array TODO state change info in the logbooks doesn't get exported to [[logbook_notes]]. Caveat: This feature works only if the `org-log-note-headings` variable is left at its default value.
This commit is a small workaround to make the TOML generation for `logbook_notes` to work on Emacs 26.3 as well. The plist worked fine too, but only on Emacs 27+. Using plist gives a runtime error in map-do/seq-do code on Emacs 26.3. See https://lists.gnu.org/r/help-gnu-emacs/2022-05/msg00022.html for reference.
Now the `notes` table array is nested inside the `logbook` table.
Don't assume that the LOGBOOK drawer name will always be named "LOGBOOK".
Also make all the org-element-map lambda functions return nil for performance.
v0.4.3 adds support for TOML table arrays in nested TOML tables, and fixes the indentation when exporting multi-line TOML strings.
Improvements to this PR were added in #635. |
date
, lastmod
and notes from LOGBOOK drawers
kaushalmodi
added a commit
that referenced
this pull request
May 12, 2022
Hugo allows the presence `lastmod` and no `date` front-matter. In that case, the `.Date` and `.Lastmod` both get set to the `lastmod` front-matter value. Ref: #504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203
logbook.notes
TOML Table arraydate
from LOGBOOK state changeslastmod
from LOGBOOK state changes:LOGBOOK:
drawer exportsDocumentation
https://ox-hugo.scripter.co/doc/drawers/
Example usage
scripter.co commit # cae86abc