Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear language bug #66

Open
wants to merge 7 commits into
base: kavilla/editor_toggle
Choose a base branch
from

Conversation

sejli
Copy link

@sejli sejli commented Jun 12, 2024

Description

Clears userQueryLanguage and userQueryString when switching languages.

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

kavilla and others added 7 commits June 11, 2024 02:51
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Restore language switcher

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

delete unused styles

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

clean up unneeded references

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

clean up unused code paths and add test

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

fix tests

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Unify settings with enhancements

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

More clean up related to combining settings

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Set default ui setting to false

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Fix test for DE

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

clean up filter to match editor

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Sean Li <lnse@amazon.com>
@sejli sejli requested a review from kavilla as a code owner June 12, 2024 00:25
@kavilla kavilla force-pushed the kavilla/editor_toggle branch 2 times, most recently from 8d6b16e to 8a59bfe Compare June 12, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants