Skip to content

Commit

Permalink
Update breadcrumb title of isDashboardNavMenu
Browse files Browse the repository at this point in the history
opensearch-project/OpenSearch-Dashboards#4453

Modified the breadcrumbs from the dashboard plugin,
to be consistent with the actual name of the application.

We should consider not hard checking the name of the
breadcrumb but really hooking into the navigation
plugin that provides the ability to do what this
logic is doing without being hardcoded.

opensearch-project/dashboards-reporting#118

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
  • Loading branch information
kavilla committed Jul 12, 2023
1 parent 655c41c commit ed4718a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion public/components/context_menu/context_menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ const isDiscoverNavMenu = (navMenu) => {
const isDashboardNavMenu = (navMenu) => {
return (
(navMenu[0].children.length === 4 || navMenu[0].children.length === 6) &&
$('[data-test-subj="breadcrumb first"]').prop('title') === 'Dashboard'
$('[data-test-subj="breadcrumb first"]').prop('title') === 'Dashboards'
);
};

Expand Down

0 comments on commit ed4718a

Please sign in to comment.