Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pipe operator on QueryBuilder #759

Merged
merged 10 commits into from
Dec 10, 2023
Merged

add pipe operator on QueryBuilder #759

merged 10 commits into from
Dec 10, 2023

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Oct 9, 2023 •
edited
Loading

pipe method like in pandas in order to do some chaining. Related to this issue here.

@wd60622 wd60622 requested a review from a team as a code owner October 9, 2023 16:03
wd60622
wd60622 commented Oct 9, 2023
View reviewed changes
pypika/__init__.py Outdated
@@ -100,7 +100,7 @@

__author__ = "Timothy Heys"
__email__ = "theys@kayak.com"
__version__ = "0.48.9"
__version__ = "0.48.10"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the expected version update?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to bump the version separately and also start a CHANGELOG.md as well as describe all of the changes there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the version back to 0.48.9 So no version change.

Have you guys considered using the automated release notes? https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes
It'd be based on the PR labels. Might be easy way to automate 😄

@coveralls
Copy link

coveralls commented Oct 10, 2023 •
edited
Loading

Coverage Status

coverage: 98.39% (+0.003%) from 98.387% when pulling 3e6b14b on wd60622:pipe_operator into ded17eb on kayak:master.

AzisK
AzisK reviewed Oct 10, 2023
View reviewed changes
Copy link

@AzisK AzisK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but I left a comment about the library (I meant test) test as well as versioning approach

@AzisK
Copy link

AzisK commented Oct 10, 2023

Thanks for you work!

@AzisK
Copy link

AzisK commented Oct 16, 2023

Could you describe this possibility in README.rst as well?

@wd60622
Copy link
Contributor Author

wd60622 commented Oct 16, 2023

There is a new "Chaining Functions" section in the Tutorial
Screenshot 2023-10-16 at 20 05 32

@wd60622
Copy link
Contributor Author

wd60622 commented Nov 30, 2023

Any other suggestions here?

@AzisK
Copy link

AzisK commented Dec 1, 2023

Looks good to me. If no other suggestions emerge in the coming days, I will merge it

@AzisK AzisK merged commit 8841520 into kayak:master Dec 10, 2023
5 checks passed
@wd60622 wd60622 deleted the pipe_operator branch December 10, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzisK AzisK AzisK left review comments

Assignees

@wd60622 wd60622

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wd60622 @coveralls @AzisK