Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctest and mermaid title #315

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Fix doctest and mermaid title #315

merged 1 commit into from
Nov 3, 2024

Conversation

kayjan
Copy link
Owner

@kayjan kayjan commented Nov 3, 2024

Description

Mermaid title was not showing up correctly due to lack of newline

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan added the bug Something isn't working label Nov 3, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 1e184d6 Previous: 590e1b4 Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 15595.186389840244 iter/sec (stddev: 0.000016871779932126964) 15813.239318243433 iter/sec (stddev: 0.000016068648049422128) 1.01
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 699.634640296464 iter/sec (stddev: 0.000006368698646263914) 697.6540649527168 iter/sec (stddev: 0.000009293857979539144) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 12.063923022056791 iter/sec (stddev: 0.0008731797182960142) 12.289504642475327 iter/sec (stddev: 0.0030188730426521076) 1.02
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 70.85376745654534 iter/sec (stddev: 0.0028654049203164092) 70.02852391331676 iter/sec (stddev: 0.002783292145350431) 0.99
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 22563.66054811875 iter/sec (stddev: 0.0000021202596852295125) 22993.897419532954 iter/sec (stddev: 0.000007335808589769443) 1.02
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1651.7431671508916 iter/sec (stddev: 0.00006982948164821943) 1756.775642095801 iter/sec (stddev: 0.000006026600384854229) 1.06
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 118.59537464637876 iter/sec (stddev: 0.0032100624833379813) 114.43196422106281 iter/sec (stddev: 0.003602009792249738) 0.96
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 95.84371156996542 iter/sec (stddev: 0.0030992880542351615) 94.21854869544507 iter/sec (stddev: 0.0031304291075897085) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

github-actions bot commented Nov 3, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2374 / 2374) 100% (1004 / 1004) 0

@kayjan kayjan merged commit 63961b2 into master Nov 3, 2024
6 checks passed
@kayjan kayjan deleted the bugfix/mermaid-test branch November 3, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant