Fix get_tree_diff if path are substring of a modified path #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 3841978 | Previous: 502290d | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
15764.081068259398 iter/sec (stddev: 0.000016191826051350452) |
15567.982265318793 iter/sec (stddev: 0.000017582492956159462) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
684.7349738415065 iter/sec (stddev: 0.000010582489377680215) |
702.2157786902205 iter/sec (stddev: 0.000002875520437650629) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
12.237583223528 iter/sec (stddev: 0.0030839092595622733) |
12.367276407011657 iter/sec (stddev: 0.0030086114383326623) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
72.7363028731529 iter/sec (stddev: 0.002611607325984039) |
70.84028109720458 iter/sec (stddev: 0.0030997098434311253) |
0.97 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
23185.448811979608 iter/sec (stddev: 0.000008008125718686985) |
23002.43940884443 iter/sec (stddev: 0.000002349927964654842) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1652.563688151423 iter/sec (stddev: 0.000007903898178052692) |
1637.547255520977 iter/sec (stddev: 0.00006586346113132478) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
128.04282899463345 iter/sec (stddev: 0.0023908657715922127) |
118.16086536006159 iter/sec (stddev: 0.0031499048789541476) |
0.92 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
101.86105495101967 iter/sec (stddev: 0.00226880789816257) |
94.45549904377839 iter/sec (stddev: 0.0032282295414700303) |
0.93 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When suffix is being added to path, it might have been substring of another path. This is the fix for the bug.
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)