Add method get_tree_diff_dataframe #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: f4d021c | Previous: da6793a | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
14831.415013614347 iter/sec (stddev: 0.000015538035120125577) |
14663.86391312339 iter/sec (stddev: 0.00001918953453884157) |
0.99 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
647.7203708251513 iter/sec (stddev: 0.0000417450387751307) |
620.4015064835517 iter/sec (stddev: 0.000018626323986998607) |
0.96 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
11.527330322677425 iter/sec (stddev: 0.0025230445350907594) |
11.345509359694578 iter/sec (stddev: 0.007827341424602558) |
0.98 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
64.46777923763104 iter/sec (stddev: 0.003996276694248504) |
63.027519460014226 iter/sec (stddev: 0.00445641660332068) |
0.98 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
22410.545506179933 iter/sec (stddev: 0.000008399933586656503) |
22548.982027049115 iter/sec (stddev: 0.000007872926900986308) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1650.7502701237881 iter/sec (stddev: 0.000010573296988261747) |
1614.4038402140397 iter/sec (stddev: 0.000013262070524371005) |
0.98 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
116.30666149428434 iter/sec (stddev: 0.0033420660964861505) |
101.64071284614732 iter/sec (stddev: 0.00468543477187637) |
0.87 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
91.48393520599221 iter/sec (stddev: 0.0033760325364061796) |
86.11025857171812 iter/sec (stddev: 0.0044134609977344716) |
0.94 |
This comment was automatically generated by workflow using github-action-benchmark.
|
kayjan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add method to retrieve tree diff in dataframe, which allows for customised handling and processing if required.
Testing
No additional tests needed as the current code is abstracted out. One binary node test is added for coverage.
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)