Release 1.0.0 - allow for omniauth 2.0 series #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fails in condition of omniauth 2.0+. refs kazasiki#32
koshilife
changed the title
| @@ -21,7 +21,7 @@ def callback_phase | |||
|
|
|||
| def callback_url | |||
| # Fixes regression in omniauth-oauth2 v1.4.0 by https://github.com/intridea/omniauth-oauth2/commit/85fdbe117c2a4400d001a6368cc359d88f40abc7 | |||
| options[:callback_url] || (full_host + script_name + callback_path) | |||
| options[:callback_url] || (full_host + callback_path) | |||
There was a problem hiding this comment.
is this gem broken with omni_auth 2 without this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @kazasiki
Please check PR #33 ahead.
Could you review this PR about #32 issue?
I tested manually in remote server with https communication environment, and confirmed following.
If you want to try my branch, you can use like following in your Gemfile.