Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Sine and Cosine transform #170

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tsunhopang
Copy link
Collaborator

Just adding good-to-have functions

@tsunhopang tsunhopang requested a review from kazewong October 18, 2024 19:08
@tsunhopang tsunhopang self-assigned this Oct 18, 2024
@kazewong
Copy link
Owner

@tsunhopang The PR looks fairly simple to me. One more thing to add: I think we can just define the sine and cosine transform as you do now, remove the existing arcsine transform class and just declare the arcsine transform using the reverse_bijective_transform

def reverse_bijective_transform(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants