Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom validator #35

Merged
merged 6 commits into from
Oct 2, 2022
Merged

Custom validator #35

merged 6 commits into from
Oct 2, 2022

Conversation

Antonboom
Copy link
Contributor

@Antonboom Antonboom commented Sep 25, 2022 •
edited
Loading

Closes #15

@kazhuravlev look at the commits to understand history of changes :)

@Antonboom Antonboom changed the title Custom validator WIP: Custom validator Sep 25, 2022
@Antonboom Antonboom changed the title WIP: Custom validator Custom validator Sep 25, 2022
kazhuravlev
kazhuravlev reviewed Sep 30, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
kazhuravlev
kazhuravlev requested changes Sep 30, 2022
View reviewed changes
Copy link
Owner

@kazhuravlev kazhuravlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent solution, but I have several suggestions.

@Antonboom
Copy link
Contributor Author

Made pipelines green.

@kazhuravlev kazhuravlev merged commit 74096be into kazhuravlev:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazhuravlev kazhuravlev kazhuravlev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: support own validator using
2 participants
@Antonboom @kazhuravlev