Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ConnectionContext constructors #7

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

pranaysashank
Copy link

Fixes vincenthz#45

@kazu-yamamoto
Copy link
Owner

In general, I would like to export constructors from (new) Internal module for backward compatibility.

@pranaysashank
Copy link
Author

@kazu-yamamoto How about moving the Types module to exposed modules instead?

@kazu-yamamoto
Copy link
Owner

Sorry for the delay.
I prefer Internal because we don't have to take care of backward compatibility.

@pranaysashank
Copy link
Author

@kazu-yamamoto moved the export to an Internal Module

@kazu-yamamoto kazu-yamamoto self-requested a review December 6, 2024 05:33
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit fb62f5d into kazu-yamamoto:main Dec 6, 2024
@kazu-yamamoto
Copy link
Owner

Merged and released.
Thank you for your contribution!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 30, 2025
# CHANGELOG

## Version 0.4.3

* Creating the `Internal` module and export the `ConnectionContext` constructor.
  [#7](kazu-yamamoto/crypton-connection#7)

## Version 0.4.2

* Using data-default.

## Version 0.4.1

* Preparing for tls v2.1

## Version 0.4.0

* Add support for overriding the TLS clientSupported member in TLSSettingsSimple
  [#3](kazu-yamamoto/crypton-connection#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export globalCertificateStore field of ConnectionContext
2 participants