Avoid buffer overflow in runStreamingBuilder
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `runStreamingBuilder`, if the `Builder` results in `More`, we were discarding the minimum required buffer size for the continuation contained in the `More`. In some (apparently rare) circumstances, this minimum required size may be less than the actual space we have left in the buffer, resulting in a buffer overflow when we run the writer. We now compare the room left in the buffer with the minimum size indicated by the `More` and flush before writing instead of overflowing the buffer in such cases.
kazu-yamamoto
approved these changes
Jun 17, 2024
|
A new version has been released. |
This was referenced Jun 18, 2024
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 30, 2025
## 0.3.0 * Breaking change: fillFileBodyGetNext takes Sentinel instead of IO () to close files on time. ## 0.2.1 * Add outBodyCancel to OutBodyIface [#11](kazu-yamamoto/http-semantics#11) * Documentation improvement. [#10](kazu-yamamoto/http-semantics#10) [#11](kazu-yamamoto/http-semantics#11) ## 0.2.0 * Introduce `responseStreamingIface` [#9](kazu-yamamoto/http-semantics#9) ## 0.1.2 * Avoid buffer overflow in fillBufBuilderOne [#4](kazu-yamamoto/http-semantics#4) ## 0.1.1 * Avoid buffer overflow in runStreamingBuilder [#3](kazu-yamamoto/http-semantics#3) ## 0.1.0 * Make it possible to guarantee that final DATA frame is marked end-of-stream. [#2](kazu-yamamoto/http-semantics#2) ## 0.0.1 * Defining getResponseBodyChunk'. [#1](kazu-yamamoto/http-semantics#1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
runStreamingBuilder, if theBuilderresults inMore, we were discarding the minimum required buffer size for the continuation contained in theMore. In some (apparently rare) circumstances, this minimum required size may be less than the actual space we have left in the buffer, resulting in a buffer overflow when we run the writer. We now compare the room left in the buffer with the minimum size indicated by theMoreand flush before writing instead of overflowing the buffer in such cases.