Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using OutBodyIface #5

Merged
merged 1 commit into from
Jun 12, 2024
Merged

using OutBodyIface #5

merged 1 commit into from
Jun 12, 2024

Conversation

kazu-yamamoto
Copy link
Owner

This catches up the changes in kazu-yamamoto/http-semantics#2

@edsko I think I should fix the code marked with fixme. QUIC's FIN can send by shutdownStream. But I don't know how to interact with the trailer maker.

@edsko
Copy link

edsko commented Jun 11, 2024

I think the trailers maker actually is fine. We could conceivable tell it that this chunk is the final one, but it's not critical (at least, it's not for me). This PR looks fine me, except that perhaps pushFinal does not actually provide any guarantees over push; but perhaps that is not necessary for HTTP3? Maybe the only thing that needs to change is that the documentation over outBodyPushFinal needs to change a bit, and should just say something like "this information may be used to ensure that..", rather than the stronger wording it currently has?

@kazu-yamamoto kazu-yamamoto merged commit 650c5a1 into main Jun 12, 2024
0 of 8 checks passed
@kazu-yamamoto kazu-yamamoto deleted the out-body-iface branch June 12, 2024 00:35
@kazu-yamamoto
Copy link
Owner Author

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants