Change defaultMaxData
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion in `defaultMaxData` Haddock comment.
|
I would like to merge this PR. Please give look at kazu-yamamoto/http2#127. |
|
A new version has been released. |
This was referenced Jul 2, 2024
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 30, 2025
## 0.1.4 * Using Integer instead of Int in LRUCache. ## 0.1.3 * Simplify `maybeOpenRxWindow` and improve docs [#7](kazu-yamamoto/network-control#7) ## 0.1.2 * introducing a minimum size for window update [#5](kazu-yamamoto/network-control#5) ## 0.1.1 * Change defaultMaxData [#4](kazu-yamamoto/network-control#4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in
defaultMaxDataHaddock comment.As the comment warns, if this value is less than what we have set it to here, then we need enough concurrent workers on the server to process the max number of concurrent streams. Currently in
http2, the default number of workers is 8. An alternative to this PR is to changehttp2so that it spawnsmaxConcurrentStreamsnumber of workers by default. Let me know what you think!