Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/b25 sys io api #49

Merged
merged 32 commits into from
Jul 23, 2023
Merged

Refactor/b25 sys io api #49

merged 32 commits into from
Jul 23, 2023

Conversation

kazuki0824
Copy link
Owner

API仕様を整理し、futuresがいらないようにした

@kazuki0824 kazuki0824 added the documentation Improvements or additions to documentation label Jul 9, 2023
@kazuki0824 kazuki0824 self-assigned this Jul 9, 2023
@kazuki0824
Copy link
Owner Author

ToDo: ドキュメンテーションコメントをつける

@kazuki0824
Copy link
Owner Author

kazuki0824 commented Jul 9, 2023 •
edited
Loading

b25-sys

  • block00, block40のIF整理してマイナーバージョンを上げる
  • typesのpubの範囲を見直す

recisdb

  • 新APIに対応させる
  • 上に伴い、Tuner部分の構造を変える

@kazuki0824 kazuki0824 enabled auto-merge July 9, 2023 09:48
@kazuki0824
Copy link
Owner Author

kazuki0824 commented Jul 9, 2023 •
edited
Loading

Tuner部分の仕様

  • UntunedTunerはnewを独自で持つ。Tunableを実装
  • TunerはTunableとAsyncBufReadとfn signal_quality()->f64を実装
  • Tunableはfn tune(ch,lnb)->Resultを持つ

@kazuki0824 kazuki0824 disabled auto-merge July 9, 2023 15:20
@kazuki0824
Copy link
Owner Author

tuneの度にinnerを取り出してTunerを再構成する

@kazuki0824 kazuki0824 requested a review from tsukumijima July 13, 2023 17:21
@kazuki0824
Copy link
Owner Author

kazuki0824 commented Jul 13, 2023 •
edited
Loading

あとは出力内容整えるのと動作確認をすればOK(まだできていない)

@kazuki0824 kazuki0824 enabled auto-merge July 14, 2023 08:42
@kazuki0824 kazuki0824 disabled auto-merge July 22, 2023 11:41
@kazuki0824 kazuki0824 enabled auto-merge (squash) July 22, 2023 11:41
@kazuki0824 kazuki0824 disabled auto-merge July 22, 2023 14:02
@kazuki0824 kazuki0824 enabled auto-merge (squash) July 22, 2023 16:36
@kazuki0824 kazuki0824 disabled auto-merge July 23, 2023 17:25
@kazuki0824 kazuki0824 merged commit 7571444 into master Jul 23, 2023
@kazuki0824 kazuki0824 deleted the refactor/b25-sys-io-api branch July 29, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsukumijima tsukumijima Awaiting requested review from tsukumijima

Assignees

@kazuki0824 kazuki0824

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kazuki0824