Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$te will return false for empty strings #515

Closed
MrWook opened this issue Feb 5, 2019 · 2 comments · May be fixed by tt9133github/snyktest#3 or ajesse11x/vuetify#5
Closed

$te will return false for empty strings #515

MrWook opened this issue Feb 5, 2019 · 2 comments · May be fixed by tt9133github/snyktest#3 or ajesse11x/vuetify#5
Labels
good first issue Good for newcomers Type: Bug Bug or Bug fixes

Comments

@MrWook
Copy link

MrWook commented Feb 5, 2019

With the newest version (probably with this commit bed9c39) $te will return false for empty Strings.
Before the update it returned true for empty Strings.

vue & vue-i18n version

ex: 2.5.2, 8.8.8

Reproduction Link

https://codesandbox.io/s/l4mlj428jl

Here is the same repo with the previous version:
https://codesandbox.io/s/ox9vj9x0l9

Steps to reproduce

  • click on the reproduction link
  • look on the example application

What is Expected?

  • it should print `hi hello world! true

What is actually happening?

  • it print hi hello world! false
@kazupon kazupon added Type: Bug Bug or Bug fixes help wanted Extra attention is needed good first issue Good for newcomers and removed help wanted Extra attention is needed labels Feb 10, 2019
@kimuraz
Copy link
Contributor

kimuraz commented Mar 1, 2019

Hi @kazupon, can i get this one? 😬

@kazupon
Copy link
Owner

kazupon commented Mar 1, 2019

@kimuraz
Sure! :)

kimuraz added a commit to kimuraz/vue-i18n that referenced this issue Mar 2, 2019
@kimuraz
🐛 bug(index): Fix kazupon#515 empty string not returning true
6d62519
kimuraz added a commit to kimuraz/vue-i18n that referenced this issue Mar 2, 2019
@kimuraz
🐛 bug(index): Fix kazupon#515 empty string not returning true
ee16164 
Closes kazupon#515
kimuraz added a commit to kimuraz/vue-i18n that referenced this issue Mar 2, 2019
@kimuraz
🐛 bug(index): Fix kazupon#515 empty string not returning true
7e888dd 
Closes kazupon#515
@kimuraz kimuraz mentioned this issue Mar 2, 2019
Merged
kazupon pushed a commit that referenced this issue Mar 3, 2019
@kimuraz @kazupon
🐛 bug(index): Fix #515 empty string not returning true (#525) by @kim…
396c5ca 
…uraz

Closes #515
@tt9133github tt9133github mentioned this issue Sep 18, 2019
Open
@snyk-bot snyk-bot mentioned this issue Oct 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
3 participants
@kazupon @kimuraz @MrWook