Optimize path.js and format.js #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
exoego
commented
Nov 4, 2018
•
exoego
commented
- Remove redundant assignment.
- Remove redundant Array.isArray and inline emptiness check
- Remove unnecessary capture group in RegExp.
Codecov Report
@@ Coverage Diff @@
## dev #456 +/- ##
==========================================
- Coverage 95.98% 95.95% -0.04%
==========================================
Files 9 9
Lines 647 642 -5
==========================================
- Hits 621 616 -5
Misses 26 26
Continue to review full report at Codecov.
|
exoego
force-pushed
the
optimize-paths
branch
from
f8a15fe
to
09a10d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.