RE2022-218: save pre-processed trait info #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 41.39% 41.46% +0.07%
==========================================
Files 67 67
Lines 5489 5496 +7
==========================================
+ Hits 2272 2279 +7
Misses 3217 3217
☔ View full report in Codecov by Sentry. |
MrCreosote
reviewed
Aug 16, 2023
MrCreosote
reviewed
Aug 17, 2023
Tianhao-Gu
commented
Aug 17, 2023
| @@ -125,13 +125,13 @@ | |||
| # microtrait_trait-displaynamelong column as the column description, and | |||
| # microtrait_trait-value as the cell value | |||
| _MICROTRAIT_TO_SYS_TRAIT_MAP = { | |||
| loader_common_names.MICROTRAIT_TRAIT_NAME: loader_common_names.SYS_TRAIT_ID, | |||
| # loader_common_names.MICROTRAIT_TRAIT_NAME: loader_common_names.SYS_TRAIT_ID, | |||
There was a problem hiding this comment.
commented them out so that tests can pass. Those will be removed in the following PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.