Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCT-1199 hide the new run button #1362

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Conversation

briehl
Copy link
Member

@briehl briehl commented Jul 18, 2018

In Jupyter Notebook 5.6.0, there's a new run button that shows up on hover over any code cell. ( see this PR: jupyter/notebook#3535 Clicking it runs that cell. Pretty nifty, but it breaks a number of different design things we have, including how app cells are supposed to run.

This is the short term fix so we can use their security fixes - just hide the new thing.

@briehl briehl requested a review from eapearson July 18, 2018 22:17
@briehl briehl changed the title hide the new run button SCT-1199 hide the new run button Jul 18, 2018
@briehl briehl merged commit d510bf3 into kbase:develop Jul 18, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 13.128% when pulling 83d982e on briehl:jupyter-5.6.0 into c6cb4aa on kbase:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants