-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAUP-729: no more magic job attributes #2972
base: DATAUP-729-just-job-ts
Are you sure you want to change the base?
Conversation
…eturn their current state instead of triggering a job look up
Codecov Report
@@ Coverage Diff @@
## develop #2972 +/- ##
===========================================
+ Coverage 73.25% 73.27% +0.01%
===========================================
Files 36 36
Lines 3903 3902 -1
===========================================
Hits 2859 2859
+ Misses 1044 1043 -1
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add the new retry_ids
in jm.retry_jobs
? Either manually or with a force refresh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops going to change status to "request changes" because I forgot to ask about refreshing any new retry_ids
self.assertCountEqual(batch_job.children, reg_child_jobs) | ||
self.assertCountEqual(batch_job._acc_state["child_jobs"], new_child_ids) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can go back in, but ofc like self.assertCountEqual(batch_job.child_jobs, new_child_ids)
Description of PR purpose/changes
Removing the 'magic' from retry_ids and child_jobs so that they now return their current state instead of triggering a job look up.
Jira Ticket / Issue
Related Jira ticket: https://kbase-jira.atlassian.net/browse/DATAUP-729
DATAUP-69 Adds a PR template
)Testing Instructions
Dev Checklist: