UIP-36 use the anonymous user id in Google Analytics calls #3345
Conversation
| @@ -99,7 +105,10 @@ def password_from_settings(cls, settings): | |||
|
|
|||
| @classmethod | |||
| def login_available(cls, settings): | |||
| """Whether this LoginHandler is needed - and therefore whether the login page should be displayed.""" | |||
| """ | |||
| Whether this LoginHandler is needed - and therefore whether the login page should be | |||
| @@ -83,7 +83,7 @@ def get(self, path): | |||
| kill_kernel=False, | |||
| mathjax_url=self.mathjax_url, | |||
| google_analytics_id=URLS.google_analytics_id, | |||
| userName=kbase_env.user, | |||
| anon_user_id=kbase_env.anon_user_id, | |||
There was a problem hiding this comment.
This line is what this whole chain of PRs is about.
There was a problem hiding this comment.
One small edit for a programmer, one GA4 leap for programmer kind!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #3345 +/- ##
===========================================
+ Coverage 29.25% 29.35% +0.09%
===========================================
Files 496 497 +1
Lines 50512 50579 +67
===========================================
+ Hits 14779 14845 +66
- Misses 35733 35734 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
@briehl I think you just need to merge in the current develop branch |
|
Kudos, SonarCloud Quality Gate passed!
|
Description of PR purpose/changes
This uses the previously introduced
get_user_infocall to set up the anonymous user id and send it off to Google Analytics. There's a few other minor tweaks here, too - the anon id gets added to the user's environment on session startup, and some bits of linting cleanup.TODO:
List any dependencies that are required for this change.
Jira Ticket / Issue
Related Jira ticket: https://kbase-jira.atlassian.net/browse/UIP-36
DATAUP-69 Adds a PR template)Testing Instructions
Dev Checklist:
Updating Version and Release Notes (if applicable)