Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-51 fix downloader app inputs #3606

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Conversation

briehl
Copy link
Member

@briehl briehl commented Jul 25, 2024

Description of PR purpose/changes

The downloader apps (from the STAGING and JSON button options) make app cells that should (used to) get autopopulated with the object used to trigger the download, but haven't for a while. They should now do so again!

FWIW, I think this is more bleedover from moving to setting object inputs to UPAs sometime last year.

Jira Ticket / Issue

Related Jira ticket: https://kbase-jira.atlassian.net/browse/UIP-51

  • Added the Jira Ticket to the title of the PR (e.g. DATAUP-69 Adds a PR template)

Testing Instructions

  • Details for how to test the PR:
  • Tests pass locally and in GitHub Actions
  • Changes available by spinning up a local narrative and navigating to X to see Y

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • (JavaScript) I have run Prettier and ESLint on changed code manually or with a git precommit hook
  • [n/a] (Python) I have run Ruff format and check on changed Python code manually or with a git precommit hook
  • Any dependent changes have been merged and published in downstream modules

Updating Version and Release Notes (if applicable)


## Version 5.4.1
- UIP-51 fix issue where JSON and STAGING download apps aren't getting properly instantiated with object inputs.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also alphabetized the dependency update list.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.91%. Comparing base (be7c6ca) to head (8ae5832).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3606   +/-   ##
========================================
  Coverage    25.90%   25.91%           
========================================
  Files          461      461           
  Lines        46652    46652           
========================================
+ Hits         12087    12090    +3     
+ Misses       34565    34562    -3     
Files Coverage Δ
...gets/narrative_core/kbaseNarrativeDownloadPanel.js 94.78% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b408b78...8ae5832. Read the comment docs.

Base automatically changed from july_24_dep_updates to develop July 26, 2024 13:38
Copy link

sonarcloud bot commented Jul 26, 2024

@briehl briehl merged commit e4668ed into develop Jul 26, 2024
9 of 10 checks passed
@briehl briehl deleted the UIP-51-fix-staging-dl-input branch July 26, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants