Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-1440 Update dropzone_area.html #3654

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

bio-boris
Copy link
Contributor

@bio-boris bio-boris commented Sep 9, 2024

Description of PR purpose/changes

  • Due to various staging service fixes not yet available, causing files to fail over 2.5 or 3 GB, and the recent cloudflare migration, which limits uploads to 5GB, we should update our messaging.
  • This is a known issue that has been happening for a long time.

Testing Instructions

  • Details for how to test the PR:
  • Tests pass locally and in GitHub Actions
  • Changes available by spinning up a local narrative and navigating to staging area to see the dropzone text

Dev Checklist:

  • My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • (JavaScript) I have run Prettier and ESLint on changed code manually or with a git precommit hook
  • (Python) I have run Ruff format and check on changed Python code manually or with a git precommit hook
  • Any dependent changes have been merged and published in downstream modules

Updating Version and Release Notes (if applicable)

Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@bio-boris bio-boris changed the title Update dropzone_area.html DEVOPS-1440 Update dropzone_area.html Sep 9, 2024
@briehl
Copy link
Member

briehl commented Oct 3, 2024

I see this is still in draft. Are you still messing with text? Want some feedback?

@briehl
Copy link
Member

briehl commented Oct 3, 2024

There's also this abandoned PR, which is a doozy, but has other similar solutions. #3312

@bio-boris
Copy link
Contributor Author

I think that once we have the docs merged by Ellen we should make sure that this PR reflects the language of the upload docs. Sure, feedback is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants