refactors buildObjectIdentity into super class #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sole purpose of this pull request is to cause merge pain for Bill. Well, okay, not sole purpose. Primary, probably.
Anyway, I noticed that we've had a proliferation of buildObjectIdentity methods in the system that are all identical. So this just refactors them and rips out the common method from the individual widgets and puts it up into the superclass in kbwidget. I know that we have other redundant methods, but this is the one that jumped out at me.
This has not been thoroughly tested - I made sure that a few narratives I had spun up, but I didn't actually have anything to test the actual affected widgets. See first comment about causing merge pain for Bill.
That said, it shouldn't cause any problems, since it's just refactoring a redundant method into a single definition in a common superclass. No functionality should change.
This is strictly a technical debt pull request, and can be integrated at leisure. No functionality changes (AFAIK), no new features are added. So I'll defer as to when is the most opportune time to include it, if at all.