DATAUP-682: Add import spec writers for xsv files #155
Conversation
Will eventually be hooked up to a service endpoint to allow the narrative to generate import templates on command
Allows the app class to tell the difference between bad input and unexpected failures (e.g. fail to open file, etc)
|
Kudos, SonarCloud Quality Gate passed!
|
MrCreosote
changed the title
| + f"{_COLUMN_STR} {cols}{_HEADER_SEP} {_VERSION_STR} {_VERSION}"]) | ||
| pids = [i[0] for i in dt[_ORDER_AND_DISPLAY]] |
There was a problem hiding this comment.
What does pid stand for?
| _check_import_specification(types) | ||
|
|
||
|
|
||
| class ImportSpecWriteException(Exception): |
There was a problem hiding this comment.
Probably YAGNI, but we may want to consider creating an StagingServiceException(Exception) and then deriving new exceptions from StagingServiceException instead of Exception, to allow for catching Staging Service Exceptions and Exceptions
try:
except StagingServiceException
except Execption
There was a problem hiding this comment.
Sounds good, made an issue. Next time I touch the code base I'll do it
| test.env | ||
| run_tests_single.sh |
There was a problem hiding this comment.
Yeah, I put it in the gitignore so it didn't get checked in accidentally. It's just a hack to run_tests.sh to allow running a single file of tests
Will eventually be hooked up to a service endpoint to allow the narrative
to generate import templates on command
@briehl heads up if you're interested