CE-99: use camelCase consistently for variable names containing 'ID' and 'URL' #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #666 +/- ##
==========================================
Coverage 86.70% 86.70%
Complexity 5399 5399
==========================================
Files 242 242
Lines 18288 18288
Branches 2677 2677
==========================================
Hits 15857 15857
Misses 1962 1962
Partials 469 469 |
ialarmedalien
force-pushed
the
CE-99_credit_metadata
branch
from
3405604
to
d46558b
Compare
ialarmedalien
force-pushed
the
CE-99_case_changes
branch
from
3f7dce1
to
4e0a229
Compare
ialarmedalien
changed the base branch from
develop
to
CE-100_credit_metadata_entry
ialarmedalien
changed the title
ialarmedalien
commented
Aug 16, 2023
| @@ -40,7 +40,7 @@ while [ $counter -lt $max_retries ]; do | |||
| fi | |||
| echo "Waiting for the workspace to be ready..." | |||
| counter=$(( counter + 1)) | |||
| sleep 2 | |||
| sleep 5 | |||
There was a problem hiding this comment.
wait slightly longer during test start up in case GitHub is being slow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AKA the pull request of the beast
This PR converts the acronyms and abbreviations used in credit engine field names to use camel case, instead of a mixture of camel case and all caps. This promotes legibility and allows devs to apply consistent rules to method and attribute naming instead of having to wonder which acronyms do get all caps (ID? URL? HTTP? etc.) and which don't.
See https://google.github.io/styleguide/javaguide.html#s5.3-camel-case for the rules used.