Simplify setting workspace metadata & add tests #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in preparation for setting object admin metadata which will hopefully reuse the code
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #694 +/- ##
=============================================
+ Coverage 87.42% 87.44% +0.01%
- Complexity 5193 5195 +2
=============================================
Files 223 223
Lines 17319 17309 -10
Branches 2546 2545 -1
=============================================
- Hits 15141 15135 -6
+ Misses 1711 1708 -3
+ Partials 467 466 -1 |
|
|
||
| throws WorkspaceCommunicationException, CorruptWorkspaceDBException { | ||
| // TODO NOW CODE integrate keys to remove (below) into this method and do it all in | ||
| // one shot |
There was a problem hiding this comment.
I tabbed it in to make it clear it's a continuation of the TODO
Comment on lines
+751
to
+758
| if (ur.getModifiedCount() == 1) { //ok, it worked | ||
| return time; | ||
| } else if (attempts >= maxattempts) { | ||
| throw new WorkspaceCommunicationException( | ||
| String.format("Failed to update metadata %s times", attempts)); | ||
| } else { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
if you were having an anti-indentation day, you could do:
if (ur.getModifiedCount() == 1) { //ok, it worked
return time;
}
if (attempts >= maxattempts) {
throw new WorkspaceCommunicationException(
String.format("Failed to update metadata %s times", attempts));
}
return null;
There was a problem hiding this comment.
I actually prefer the elses here, makes things a bit easier to read for me. Not a big deal though
ialarmedalien
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in preparation for setting object admin metadata which will hopefully reuse the code