Add method to set admin meta to DAO #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and alter all the methods that touch object information to copy or return it correctly. Ideally we would've: * Made some type of field manager so mongo field lists aren't respecified all over the place * Added less integration-y tests for the altered methods in MongoWorkspaceDBTest, rather than jamming tests into WorkspaceTest However, that would have added several days to this project which we don't have.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #700 +/- ##
=============================================
+ Coverage 87.47% 87.52% +0.04%
- Complexity 5222 5228 +6
=============================================
Files 224 224
Lines 17344 17385 +41
Branches 2560 2561 +1
=============================================
+ Hits 15172 15216 +44
Misses 1706 1706
+ Partials 466 463 -3 |
| Fields.WS_META, | ||
| Fields.WS_MODDATE); | ||
| } catch (NoSuchObjectException e) { | ||
| throw new RuntimeException("You divided by zero, didn't you, you absolute muppet", e); |
Comment on lines
+132
to
+134
| * UPDATE 2023/10/20: 9k lines long, let's see if we can get it to 10k, ok gang?! | ||
| * If we work really hard and give it our all, we can make a difference today! | ||
| * See, that's an extra line right there! And so is this, yay! |
ialarmedalien
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and alter all the methods that touch object information to copy or return it correctly.
Ideally we would've:
However, that would have added several days to this project which we don't have.