Fix build and tests #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google downloads seem to work now anyway, given up to date urls retrieved from google drive. The lesson to be learned here is use libraries rather than fragile string parsing. To that end, we should probably use an actual Google drive client rather than the hack I've got working for now Also stop running tests twice, which has been happening for 4 years apparently
MrCreosote
requested review from
jsfillman,
qzzhang and
Tianhao-Gu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 70.89% 71.53% +0.63%
==========================================
Files 5 5
Lines 1182 1212 +30
==========================================
+ Hits 838 867 +29
- Misses 344 345 +1 ☔ View full report in Codecov by Sentry. |
|
The coverage report seems to have multiple prior PRs included, as there are changes not included in this PR. For some reason this repo was deactivated in codecov |
Closed
Tianhao-Gu
approved these changes
Mar 13, 2024
| @@ -11,6 +11,7 @@ | |||
| import subprocess | |||
There was a problem hiding this comment.
We need to bump version as current release version is also 0.2.0
| parsedurl = urlparse.urlparse(file_url) | ||
| query = {} | ||
| if parsedurl.query: | ||
| # should we catch an error here? |
There was a problem hiding this comment.
I don't have a strong option. Probably fine as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google downloads seem to work now anyway, given up to date urls retrieved from google drive. The lesson to be learned here is use libraries rather than fragile string parsing. To that end, we should probably use an actual Google drive client rather than the hack I've got working for now
Also stop running tests twice, which has been happening for 4 years apparently