Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

cpp is not the only extension for C++ #19

Closed
ztdwu opened this issue Dec 18, 2015 · 7 comments
Closed

cpp is not the only extension for C++ #19

ztdwu opened this issue Dec 18, 2015 · 7 comments

Comments

@ztdwu
Copy link

ztdwu commented Dec 18, 2015

{ ".cc", ".cpp", ".cp", ".cxx", ".c++", ".C" }

As far as I know, these are all valid extensions for C++ source code, with cc and cpp being the most popular. Currently cargo-count only supports cpp.

@Vinatorul
Copy link
Collaborator

Thank you for your contibution!
Yeah, there are more valid extensions for other languages, too, .htm for html, .h++, .h for c++ headers, etc.
It will be done when @kbknapp or I will have some free time 😉
I think I can try it tonight or tommorow.

@kbknapp
Copy link
Owner

kbknapp commented Dec 18, 2015

@Vinatorul should be as easy as adding another line(s) below this one with the additional extensions.

edit: fixed link

@ztdwu
Copy link
Author

ztdwu commented Dec 24, 2015

I don't think the fix quite worked.

> touch a.cc
> touch a2.cc
> touch a3.cc
> ls
a.cc a2.cc a3.cc

> ~/workspace/cargo-count/target/release/cargo-count count 
Gathering information...
         Language  Files  Lines  Blanks  Comments  Code
         --------  -----  -----  ------  --------  ----
         C++       1      0      0       0         0
         C++       1      0      0       0         0
         C++       1      0      0       0         0
         --------  -----  -----  ------  --------  ----
Totals:            3      0      0       0         0

homu added a commit that referenced this issue Dec 28, 2015
fix: Batch results by language, not file extension

Fixes some extensions creating multiple entries for the same language, as reported by @byteprelude in #19.
homu added a commit that referenced this issue Dec 28, 2015
fix: Batch results by language, not file extension

Fixes some extensions creating multiple entries for the same language, as reported by @byteprelude in #19.
@kbknapp kbknapp reopened this Jan 9, 2016
@m-n
Copy link
Contributor

m-n commented Jan 9, 2016

I think the multiple C++ printed lines is fixed on master, but hasn't been published to crates.io yet.

@kbknapp
Copy link
Owner

kbknapp commented Jan 31, 2016

@m-n I apologise. I'm pushing some updates now, and I'll upload the new version to crates.io.

@m-n
Copy link
Contributor

m-n commented Jan 31, 2016

@kbknapp Thanks. I don't intend to rush you; I wanted to make sure the status of the issue was clear.

@nabijaczleweli
Copy link
Contributor

This is fixed when you release current HEAD

@kbknapp kbknapp closed this as completed Sep 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants