Skip to content

Fix Issue 15816 Add exception if port range specified for discovery.zen.ping.unicast.hosts #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2017

Conversation

mortonsykes
Copy link

@mortonsykes mortonsykes commented Mar 20, 2017

Added a regex expression to determine if a port range is specified in the config file, "elasiticsearch.yml" in the "config" folder of the built application. If this is the case an exception will be thrown as this is unsupported.

example: Contents of elasiticsearch.yml

.... 
discovery.zen.ping.unicast.hosts : ["128.0.0.1", "127.0.0.1:9000", "192.0.0.1:9200-9300"]
....

In this example the third entry "192.0.0.1:9200-9300" will cause the exception to be thrown.

upi: msyk659 group: Group 1

@nik9000
Copy link

nik9000 commented Mar 20, 2017

It is usually a better choice to make the PR's title descriptive of what you are doing rather than a reference to an issue for a few reasons:

  1. When I am looking over my email to see what to review I scan the email's subjects which are the titles of the PRs. I don't have all the issues memorized so if you reference an issue I'm not going to review it.
  2. When you click the merge button you'll get a commit with the short description the same as the PR's title and it is much nicer to have descriptions instead of links in the title.

@mortonsykes mortonsykes changed the title Fix Issue 15816 Fix Issue 15816 Correct documentation of discovery.zen.ping.unicast.hosts regarding support for port ranges and add exception if port range specified Mar 20, 2017
Copy link

@StefanGor StefanGor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@mortonsykes mortonsykes changed the title Fix Issue 15816 Correct documentation of discovery.zen.ping.unicast.hosts regarding support for port ranges and add exception if port range specified Fix Issue 15816 Add exception if port range specified for discovery.zen.ping.unicast.hosts Mar 22, 2017
@mortonsykes mortonsykes force-pushed the master branch 3 times, most recently from d0dfe17 to f2b536a Compare March 23, 2017 06:31
@kblincoe kblincoe merged commit fd15031 into kblincoe:master Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants