Icon object #9
Merged
Icon object #9
+418
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This really light object allow us to not expose an array (ex: RegistryInterface), have a immutable object, and allow us some interesting manipulation (toHtml, withAttributes, ..) while keeping high performances.
(i'd put that on an Icon class, but this is another PR 👼) I really would like to 1. normalize things as early as possible 2. don't have multiple place where those checks are done, the main risk beeing they are not done..
This was referenced Feb 3, 2024
Closed
kbond
reviewed
Feb 3, 2024
| * @throws \InvalidArgumentException if the ID is not valid | ||
| * @see isValidId() | ||
| */ | ||
| public static function idToName(string $id): string |
Owner
There was a problem hiding this comment.
we need to actually use these new methods now, right?
Author
There was a problem hiding this comment.
Of course, i try to do micro step by micro step because the rebase dance is not my first talent :)
kbond
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.