Fix for screen rotation issue #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compiler warning "Forced cast from 'UIViewController?' to 'UIViewController' only unwraps optionals; did you mean to use '!'?"
Adds NavigationController as root to storyboard to make issue with screen rotation visible
When rotating screen while overlay vc is presented the underlying presenting vc gets corrupted after dismissal. I believe this is a bug in iOS11 and higher, because it does not happen on iOS10. Due to this, resetting the frame to screen size is more a workaround then a proper fix, feel free to suggest a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kyle,
i've found a solution for the issue described in issue #1 and also in the stackoverflow conversation by @trapper-.
I believe it's caused by a bug in iOS11 and higher, because it does not happen on iOS10 and i don't have any other explanation. Due to this, my change is more an ugly workaround then a proper fix, but maybe you want to merge it because it could be helpful for other people. I've also embedded the main vc in a navigation controller, because the issue was only visible in this constellation.
Thanks for your great work in this repo, this was very helpful for me.
cheers
Chris