optimize lookups when adding event listeners

kbrsh · May 26, 2017 · 2509ffd · 2509ffd
1 parent f05e97f
commit 2509ffd
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 17 deletions.
diff --git a/dist/moon.js b/dist/moon.js
@@ -2262,11 +2262,12 @@
 
         // Final event listener code
         var code = 'function(event) {' + modifiers + 'instance.callMethod("' + methodToCall + '", [' + params + '])}';
-        var eventListeners = vnode.meta.eventListeners[eventType];
-        if (eventListeners === undefined) {
-          vnode.meta.eventListeners[eventType] = [code];
+        var eventListeners = vnode.meta.eventListeners;
+        var eventHandlers = eventListeners[eventType];
+        if (eventHandlers === undefined) {
+          eventListeners[eventType] = [code];
         } else {
-          eventListeners.push(code);
+          eventHandlers.push(code);
         }
       }
     };
@@ -2328,11 +2329,12 @@
         var code = 'function(event) {instance.set("' + keypath + '", event.target.' + valueProp + ')}';
 
         // Push the listener to it's event listeners
-        var eventListeners = vnode.meta.eventListeners[eventType];
-        if (eventListeners === undefined) {
-          vnode.meta.eventListeners[eventType] = [code];
+        var eventListeners = vnode.meta.eventListeners;
+        var eventHandlers = eventListeners[eventType];
+        if (eventHandlers === undefined) {
+          eventListeners[eventType] = [code];
         } else {
-          eventListeners.push(code);
+          eventHandlers.push(code);
         }
 
         // Setup a query used to get the value, and set the corresponding dom property