⚡ perf boost: handle case when there are no children and remove all o…

…f them
kbrsh · Mar 29, 2017 · 577fe98 · 577fe98
1 parent 339cabe
commit 577fe98
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 9 deletions.
diff --git a/dist/moon.js b/dist/moon.js
@@ -767,10 +767,20 @@
             newText.meta.el = node.firstChild;
           }
         } else {
-          // Just Iterate through All Children
-          var totalLen = newLength > oldLength ? newLength : oldLength;
-          for (var i = 0; i < totalLen; i++) {
-            diff(oldVNode.children[i], vnode.children[i], node, instance);
+          if (newLength === 0) {
+            // No Children, Remove all Children if not Already Removed
+            if (oldLength !== 0) {
+              var firstChild = null;
+              while (firstChild = node.firstChild) {
+                removeChild(firstChild, node);
+              }
+            }
+          } else {
+            // Traverse and Diff Children
+            var totalLen = newLength > oldLength ? newLength : oldLength;
+            for (var i = 0; i < totalLen; i++) {
+              diff(oldVNode.children[i], vnode.children[i], node, instance);
+            }
           }
         }