Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature-request: support for dom-elements as el option #34

Closed
pateketrueke opened this issue Apr 15, 2017 · 1 comment
Closed

feature-request: support for dom-elements as el option #34

pateketrueke opened this issue Apr 15, 2017 · 1 comment
Assignees
@kbrsh
Labels
feature
Milestone
v0.10.0

Comments

@pateketrueke
Copy link

Currently, I cannot pass DOM instances as the el option, which is expecting an identifier.

https://github.com/KingPixil/moon/blob/5133bf21c64eccd4c49ca9b450f7ad558c30c64a/src/instance/methods.js#L151

I think something like this could work:

this.$el = typeof el === 'string' ? document.querySelector(el) : el;
@kbrsh kbrsh added this to the v0.9.1 milestone Apr 15, 2017
@kbrsh kbrsh self-assigned this Apr 15, 2017
@kbrsh kbrsh added the feature label Apr 15, 2017
@kbrsh
Copy link
Owner

kbrsh commented Apr 15, 2017

Should be coming in v0.9.1

@kbrsh kbrsh closed this as completed in 2f70afc Apr 16, 2017
kbrsh added a commit that referenced this issue Jun 8, 2017
@kbrsh
allow 'el' to be a DOM element (fixes #34)
b45502f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbrsh kbrsh

Labels
feature
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
2 participants
@pateketrueke @kbrsh