Fixes #3
Fixes #3
Conversation
There was a problem hiding this comment.
Hi @feld 👋
Thank you for your contribution!
I submitted a couple of comments related to the majority of the lines you changed. Ideally, dropping e734ef1 and 50d697a would be the easiest way of dealing with them 🙂
We currently are in the process of smoothing out all of our public repos, and as such they don't all have a "Contributing" section in their README.md yet, or a link the our organization's one, where we have a section related to how we handle changes related to formatting commits (relevant section here).
| [ | ||
| inputs: ["mix.exs", "{config,lib,test}/**/*.{ex,exs}", "priv/repo/migrations/*.exs", "priv/repo/optional_migrations/**/*.exs"] | ||
| ] |
There was a problem hiding this comment.
We avoid using mix's formatter for repos that don't use it from the beginning, reason being that the changes they apply don't have any functionnal meaning, and we try to keep an as obvious and simple as possible in the git history.
| {:credo, "~> 1.7", only: :dev}, | ||
| {:dialyxir, "~> 1.4", only: :dev}, |
There was a problem hiding this comment.
We are not planning on using credo nor dialyxir, even just as dev dependencies. We might in the future, it is just not something that we want to do in isolation, in this repo only.
We currently are in the process of cleaning up our repos, and decided that this kind of change would be discussed down the line.
We'll gladly add those later on if it is something we decide to do as an organization 🙂
various fixes as I go along testing this library for a project