Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate getLastResponse...() and request...() in Clients #391

Closed
Art4 opened this issue Mar 12, 2024 · 0 comments · Fixed by #426
Closed

Deprecate getLastResponse...() and request...() in Clients #391

Art4 opened this issue Mar 12, 2024 · 0 comments · Fixed by #426
Assignees
@Art4
Labels
code quality enhancement
Milestone
v2.8.0

Comments

@Art4
Copy link
Collaborator

Art4 commented Mar 12, 2024 •
edited
Loading

Since v2.5.0 (#370) all Clients implements the method Redmine\Http\HttpClient::request() and with v2.6.0 (#378) all API classes will have the new method Redmine\Api\...::getLastResponse() to get the last response made by the API class. The users should now use this new getLastResponse() method. Therefore the following methods should be deprecated and removed.

  • Redmine\Client\Client::requestGet()
  • Redmine\Client\Client::requestPost()
  • Redmine\Client\Client::requestPut()
  • Redmine\Client\Client::requestDelete()
  • Redmine\Client\Client::getLastResponseStatusCode()
  • Redmine\Client\Client::getLastResponseContentType()
  • Redmine\Client\Client::getLastResponseBody()

Follows #341.
@Art4 Art4 added this to the v2.7.0 milestone Mar 12, 2024
@Art4 Art4 mentioned this issue Jun 17, 2024
Closed
@Art4 Art4 modified the milestones: v2.7.0, v2.8.0 Jul 8, 2024
@Art4 Art4 self-assigned this Oct 8, 2024
@Art4 Art4 removed the pending: help wanted help and PRs are welcome label Oct 8, 2024
This was referenced Oct 8, 2024
Merged
Open
Closed
@Art4 Art4 changed the title Deprecate getLastResponseStatusCode, getLastResponseContentType and getLastResponseBody in Clients Deprecate getLastResponse...() and request...() in Clients Oct 10, 2024
@Art4 Art4 closed this as completed in #426 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Art4 Art4

Labels
code quality enhancement
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging a pull request may close this issue.

Deprecate getLastResponse...() and request...() in Clients Art4/php-redmine-api
1 participant
@Art4