-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish HttpFactory #428
Comments
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on #426 I noticed that there is no convenient alternative to call
\Redmine\Http\HttpClient::request()
because one has to implement the\Redmine\Http\Request
interface beforehand.Internally we are using the class
\Redmine\Http\HttpFactory
to createRequest
andResponse
instances. This factory class is marked as internal. I propose to make this class publicly available to make the use of\Redmine\Http\HttpClient::request()
much more easier.See also #401 (comment). The
HttpFactory
will reduce the needed code to:#391 proposes the deprecation of this methods:
Redmine\Client\Client::getLastResponseStatusCode()
Redmine\Client\Client::getLastResponseContentType()
Redmine\Client\Client::getLastResponseBody()
But publishing
HttpFactory
will allow us to deprecate even more methods:Redmine\Client\Client::requestGet()
Redmine\Client\Client::requestPost()
Redmine\Client\Client::requestPut()
Redmine\Client\Client::requestDelete()
Deprecating this methods was also kept in mind while designing the
\Redmine\Http\HttpClient::request()
method, see #341.The text was updated successfully, but these errors were encountered: