Fix file uploads #222
Fix file uploads #222
Conversation
|
thanks for the fix, |
|
Sorry, no, I do not have time to figure out how to use that. If you want your library fixed you can either fix the style yourself, or deny the PR and have broken code. |
|
So I went through all the trouble to figure out how to use php-cs-fix and it did not find anything wrong. So, what is it that you want changed?? |
Sorry, this is a library I created years ago for a very specific need and thought I could share the work with the community. I haven't used Redmine for years now, how would it sound if I'd say "I do not have time to work on this now"?
It's great fixing code, I appreciate! To me code style is equally important ! So yes, I'd rather have broken code than merging code not following the cs standard of the lib. I could indeed fix it myself, that's probably what I'll end up doing, and I won't get a penny for it (are you getting paid for using this library?).
Sorry about getting you go through all the trouble of using a tool that, I think, you should use in every single PHP project you work on. It's not much that needed fixing, as said above, I'll fix it myself! My final recommendation is that you might consider forking all the "buggy, open source free" libraries you use out there and use those forks in your projects! You'll benefit from you fixes right away and won't need to "go through all the trouble" of following the library's standards. Thanks for you help! ;) |
Attaching files to an issue does not work. Before this fix, the file redmine would attach to an issue would be empty because the curl opts to add the file are missing.
The necessary curl opts have been added for the file to be read into the body of the request.