Do not use temporary cache in Redmine\Api\...::list() methods
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.x #354 +/- ##
============================================
- Coverage 96.58% 96.57% -0.01%
Complexity 492 492
============================================
Files 27 27
Lines 1376 1374 -2
============================================
- Hits 1329 1327 -2
Misses 47 47 ☔ View full report in Codecov by Sentry. |
kbsali
approved these changes
Jan 3, 2024
Art4
deleted the
353-do-not-use-temporary-cache-in-redmineapilist-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the change of the cache if using the
list()methods and move it back in theall()(andlisting()) methods for BC.Fixes #353.