Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Group::listNames() method as replacement for Group::listing() #398

Merged

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Mar 25, 2024

Refs #338

@Art4 Art4 added this to the v2.7.0 milestone Mar 25, 2024
@Art4 Art4 self-assigned this Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (ece897d) to head (4764543).

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x     #398   +/-   ##
=========================================
  Coverage     98.47%   98.47%           
- Complexity      606      609    +3     
=========================================
  Files            29       29           
  Lines          1832     1840    +8     
=========================================
+ Hits           1804     1812    +8     
  Misses           28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4 Art4 changed the title Add list*() methods as replacement for listing() Add Group::listNames() method as replacement for Group::listing() Mar 26, 2024
@Art4 Art4 requested a review from kbsali March 27, 2024 10:13
@Art4 Art4 marked this pull request as ready for review March 27, 2024 10:13
@Art4 Art4 merged commit ae384f0 into kbsali:v2.x Apr 9, 2024
12 checks passed
@Art4 Art4 deleted the 338-replace-listing-methods-with-consistent-solution branch April 9, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant