Bump bootstrap from 4.6.2 to 5.0.0 #352

dependabot · 2024-09-17T15:56:45Z

Resolves #362
Bumps bootstrap from 4.6.2 to 5.0.0.

Release notes

v5.0.0

Highlights

#32155: Updated make-col() mixin to generate equal columns when no size is specified #32763: Added new color-scheme() mixin #33389: Dropdown menus now have option become clickable #33453: Added new docs footer #33548: Offcanvas header components are now vertically aligned #33549: Added offcanvas-top modifier #33634: Added support for .dropdown-items wrapped in <li>s #33626: Fix v5 regressions in tab dropdown functionality

🚀 Features

#32763: Add color-scheme mixin

#33389: Dropdown — Add option to make the dropdown menu clickable

#33549: Add offcanvas-top modifier

🎨 CSS

#32155: Add equal column mixin

#32763: Add color-scheme mixin

#33292: Make accordion icon rotation more natural

#33411: Fix validation feedback icon in select multiple

#33478: Make .nav-link color consistent when using buttons

#33482: Dropdown — Apply positioning only when Popper is not used

#33548: Vertically align offcanvas header components

#33549: Add offcanvas-top modifier

#33550: Spinner alignment changes

#33598: Hide validation icons from multiple selects

#33600: Have $form-check-input-border's default derive from $black

#33607: Reduce color-scheme complexity

#33642: use :read-only css selector instead [readonly] for consistency

#33658: fix: use list-group variable instead of alert

#33736: accordion: fix border-top on Firefox

☕️ JavaScript

#32439: Decouple BackDrop from modal

#33245: Decouple Modal's scrollbar functionality

#33249: Simplify Modal Config

#33250: Simplify ScrollSpy config

#33310: fix: make EventHandler better handle mouseenter/mouseleave events

#33389: Dropdown — Add option to make the dropdown menu clickable

#33429: Remove element event listeners through base component

#33451: Add missing things in hide method of dropdown

#33456: Use our isDisabled util on dropdown

#33466: Refactor dropdown's hide functionality

#33479: Fix dropdown escape propagation

#33496: Use cached noop function

... (truncated)

Commits

bf09367 Release v5.0.0 (#33647)
48ae5a7 Rewrite migration guide (#33834)
f086572 refactor(docs): Added form file input variables (#33833)
1a54286 Fix doc typo and Bootstrap Icons link (#33832)
e2df73f Update migration guide for some v5 changes (#33829)
1e6356a Neutralise more words from placeholder text (#33731)
6633845 Bump eslint-config-xo from 0.35.0 to 0.36.0 (#33646)
cb38744 Tweak toast docs (#33810)
c2ff225 Bump rollup from 2.46.0 to 2.47.0 (#33818)
c090ea2 Bump @babel/preset-env from 7.14.0 to 7.14.1 (#33819)
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

netlify · 2024-09-17T15:57:31Z

✅ Deploy Preview for s-forms-kbss ready!

Name	Link
🔨 Latest commit	`81e0a4b`
🔍 Latest deploy log	https://app.netlify.com/sites/s-forms-kbss/deploys/673b0d801449380008d2daa6
😎 Deploy Preview	https://deploy-preview-352--s-forms-kbss.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

palagdan · 2024-10-10T15:03:14Z

@blcham
I cannot simulate the issue you described here. You might want to try again in the Netlify preview, as everything looks good on my end after I fixed the bottom margin.

Could you please take a look at the result? Perhaps you might find something else.

Also, when I attempted to upgrade Bootstrap React from version 1.0.1 to 2.10.5, everything broke. The blue you see is a wizard step.

blcham · 2024-10-10T19:34:59Z

Also, when I attempted to upgrade Bootstrap React from version 1.0.1 to 2.10.5, everything broke. The blue you see is a wizard step.

Yes, I can imagine, have a look at:
https://react-bootstrap.netlify.app/docs/migrating/

Could you please take a look at the result? Perhaps you might find something else.

It would be nice to fix the invalid time first, as I cannot go over the whole form.

Could you explain the reason of the wizard step?

I do not understand. Could you reformulate the question?

blcham · 2024-11-04T13:32:02Z

@blcham should compare how it looks compared with previous version

blcham · 2024-11-07T17:24:13Z

Current state:

no need to change
mouse pointer not indicating that section is clickable
button to submit comments is outside of its pop-up
selected value of codelist is underlined

blcham · 2024-11-07T17:40:06Z

@blcham it is needed to add autocomplete with tree example into form1

Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.6.2 to 5.0.0. - [Release notes](https://github.com/twbs/bootstrap/releases) - [Commits](twbs/bootstrap@v4.6.2...v5.0.0) --- updated-dependencies: - dependency-name: bootstrap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

blcham · 2024-11-15T17:07:12Z

Align opened/closed section (might consider opened wizard step layout as well) -- here, either remove blue or add blue. I do not care that much, although I prefer having blue to show the user which of those sections are open, but I do not know how it will look after the alignment
Align bold/not bold fonts (to be honest, I do not understand why it should be bold, so I would leave it as not bold unless it has some meaning ... does it? ... I looked at bootstrap 5 examples, but I did not see components in bold font like that, but maybe I did not look well.

blcham · 2024-11-15T17:07:43Z

@palagdan, see the new issues that I found. I went over everything, so there should not be any more issues after this is done.

blcham · 2024-11-15T18:42:57Z

@palagdan

blcham

See my comments.

src/components/Question.jsx

blcham

@palagdan, I believe that you are removing another behavior again. Please take a moment to think about why it happened and let's discuss it. Hope I am not wrong, but you removed two lines that seem to be quite important:

{this.renderQuestionIcons()}
{this.props.children}

Ok, I just found what it is causing :

palagdan · 2024-11-18T09:50:26Z

@blcham
You're right, I somehow overlooked it. I’ve reverted the behavior, so it should now be working as it did before

blcham · 2024-11-18T11:34:46Z

@palagdan should i merge ?

palagdan · 2024-11-18T11:37:54Z

@blcham
I checked once more and didn't notice any strange behavior, so I believe we can merge it.

dependabot bot added the dependencies Pull requests that update a dependency file label Sep 17, 2024

This was referenced Oct 3, 2024

Resolve dependencies suggested by dependabot kbss-cvut/record-manager-ui#227

Closed

Migrate to bootstrap 5 #362

Closed

blcham force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch from 61116c1 to d1890fb Compare October 3, 2024 15:06

palagdan force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch from 29ffeea to 4ddca1a Compare October 16, 2024 08:56

blcham force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch 2 times, most recently from d8a96c7 to af52278 Compare November 4, 2024 13:27

dependabot bot and others added 7 commits November 15, 2024 13:54

[#362] Bump react bootstrap to 2.10.5

e515b75

[#362] Fix input bottom margin

264c521

[#362] Fix deprecated bootstrap classes

ae7c9ff

[#362] Fix deprecated Accordion usage

3881883

[#362] Fix: Selected value of codelist is always underlined

4e0a307

[#362] Fix: button to submit comments is outside of its pop-up

e17bf31

palagdan force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch from af52278 to e17bf31 Compare November 15, 2024 13:56

palagdan requested review from LaChope and blcham and removed request for LaChope November 15, 2024 13:57

[#362] Fix: Align opened/closed section blue color

6561bce

blcham requested changes Nov 15, 2024

View reviewed changes

src/components/Question.jsx Outdated Show resolved Hide resolved

palagdan requested a review from blcham November 15, 2024 18:58

palagdan removed the request for review from blcham November 15, 2024 18:58

palagdan force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch from 3ec324e to 7d0cc2c Compare November 15, 2024 19:02

blcham requested changes Nov 18, 2024

View reviewed changes

[#362] Fix: Align bold/not bold fonts

81e0a4b

palagdan force-pushed the dependabot/npm_and_yarn/bootstrap-5.0.0 branch from 7d0cc2c to 81e0a4b Compare November 18, 2024 09:48

blcham merged commit 83c5b10 into master Nov 18, 2024
5 checks passed

blcham deleted the dependabot/npm_and_yarn/bootstrap-5.0.0 branch November 18, 2024 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump bootstrap from 4.6.2 to 5.0.0 #352

Bump bootstrap from 4.6.2 to 5.0.0 #352

dependabot bot commented on behalf of github Sep 17, 2024 •

edited

Loading

netlify bot commented Sep 17, 2024 •

edited

Loading

palagdan commented Oct 10, 2024 •

edited

Loading

blcham commented Oct 10, 2024 •

edited

Loading

blcham commented Nov 4, 2024

blcham commented Nov 7, 2024 •

edited

Loading

blcham commented Nov 7, 2024

blcham commented Nov 15, 2024 •

edited by palagdan

Loading

blcham commented Nov 15, 2024 •

edited

Loading

blcham commented Nov 15, 2024

blcham left a comment

blcham left a comment •

edited

Loading

palagdan commented Nov 18, 2024

blcham commented Nov 18, 2024

palagdan commented Nov 18, 2024

Bump bootstrap from 4.6.2 to 5.0.0 #352

Bump bootstrap from 4.6.2 to 5.0.0 #352

Conversation

dependabot bot commented on behalf of github Sep 17, 2024 • edited Loading

v5.0.0

Highlights

🚀 Features

🎨 CSS

☕️ JavaScript

netlify bot commented Sep 17, 2024 • edited Loading

✅ Deploy Preview for s-forms-kbss ready!

palagdan commented Oct 10, 2024 • edited Loading

blcham commented Oct 10, 2024 • edited Loading

blcham commented Nov 4, 2024

blcham commented Nov 7, 2024 • edited Loading

blcham commented Nov 7, 2024

blcham commented Nov 15, 2024 • edited by palagdan Loading

blcham commented Nov 15, 2024 • edited Loading

blcham commented Nov 15, 2024

blcham left a comment

Choose a reason for hiding this comment

blcham left a comment • edited Loading

Choose a reason for hiding this comment

palagdan commented Nov 18, 2024

blcham commented Nov 18, 2024

palagdan commented Nov 18, 2024

dependabot bot commented on behalf of github Sep 17, 2024 •

edited

Loading

netlify bot commented Sep 17, 2024 •

edited

Loading

palagdan commented Oct 10, 2024 •

edited

Loading

blcham commented Oct 10, 2024 •

edited

Loading

blcham commented Nov 7, 2024 •

edited

Loading

blcham commented Nov 15, 2024 •

edited by palagdan

Loading

blcham commented Nov 15, 2024 •

edited

Loading

blcham left a comment •

edited

Loading