fix pid#124; deal with custom transformations correctly

kbwo · Oct 21, 2023 · 5d9fac2 · 5d9fac2
1 parent 563da7e
commit 5d9fac2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/speakingurl.js b/lib/speakingurl.js
@@ -1460,7 +1460,8 @@
 
         if (typeof opts === 'object') {
             maintainCase = opts.maintainCase || false;
-            customReplacements = (opts.custom && typeof opts.custom === 'object') ? opts.custom : customReplacements;
+            const customIsObject = typeof opts.custom === 'object'
+            customReplacements = (opts.custom && customIsObject) ? opts.custom : customReplacements;
             truncate = (+opts.truncate > 1 && opts.truncate) || false;
             uricFlag = opts.uric || false;
             uricNoSlashFlag = opts.uricNoSlash || false;
@@ -1511,6 +1512,8 @@
 
                 if (v.length > 1) {
                     r = new RegExp('\\b' + escapeChars(v) + '\\b', 'gi');
+                } else if (customIsObject && /^[0-9]$/.test(v)) {
+                    r = null
                 } else {
                     r = new RegExp(escapeChars(v), 'gi');
                 }

diff --git a/test/test-custom.js b/test/test-custom.js
@@ -16,6 +16,12 @@ describe('getSlug with custom replacement', function () {
             })
             .should.eql('буу');
 
+        getSlug('top 100 waterfalls', {
+                custom: ['.']
+            })
+            .should.eql('top-100-waterfalls');
+
+
         getSlug('[nodejs]', {
                 custom: {
                     '[': '[',