Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

midterm #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

k-kawa-gucci
Copy link

No description provided.

margin:0 auto;
list-style:none;
}
#nav li {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your nav styles are under your Base Typography section. It would be better to move this down to Site Specific css section.

@epilande
Copy link
Member

I've added some feedback.

Other comments:

  • I see you're using two different stylesheets for your home & about page. It's not necessary to use two, it would be better to use one stylesheet, that way you can reuse styles, & it will be easier to maintain.
  • Your images have white background. We want to save out the images without the white background (instead of white, make it a transparent background), that way we can use it on any color background.
  • Currently you have section01 grouping the hero/banner & 3 columns section. It would be easier to style them if you separate the 3 columns into a section02.

@k-kawa-gucci
Copy link
Author

Thank you ill apply the changes

On Tue, Mar 22, 2016 at 12:35 PM, Emmanuel Pilande <notifications@github.com

wrote:

I've added some feedback.

Other comments:

  • I see you're using two different stylesheets for your home & about
    page. It's not necessary to use two, it would be better to use one
    stylesheet, that way you can reuse styles, & it will be easier to maintain.
  • Your images have white background. We want to save out the images
    without the white background (instead of white, make it a transparent
    background), that way we can use it on any color background.
  • Currently you have section01 grouping the hero/banner & 3 columns
    section. It would be easier to style them if you separate the 3 columns
    into a section02


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants