Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use Windows 2019 in build-and-test-windows #177

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

jakezhu9
Copy link
Contributor

@jakezhu9 jakezhu9 commented Nov 2, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #176

2. What is the scope of this PR (e.g. component or file name):

.github/workflow

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

There is a known issue with C toolchain in windows 2022, which breaks some of our tests. So I change it to use 2019

Ref: golang/go#51007 , DataDog/dd-trace-go#2250

Already tested on my own branch https://github.com/jakezhu9/kcl-go/actions/runs/6732347534

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: jakezhu9 <jakezhu9@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6732557758

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.642%

Totals Coverage Status
Change from base Build 6701595223: 0.0%
Covered Lines: 2627
Relevant Lines: 4002

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM

@Peefy Peefy merged commit 2971be4 into kcl-lang:main Nov 2, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failed in build-and-test-windows support Go API for GetSchemaTypeMapping
3 participants